frontend/e2e/career-proofread.spec.ts (1)

59-71: ⚡ Quick win

Use SSoT/test constants instead of inline Japanese message literals in selectors.

Lines 59–71 directly embed UI strings ("例: 山田 太郎", "変更内容の確認", "変更点・校正", "この内容で保存"). Please route these through a shared message source (or stable test IDs) so copy updates don’t silently break E2E.

As per coding guidelines, “In frontend code, follow message management rules … message literals are forbidden and must use Single Source of Truth (SSoT)”.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/e2e/career-proofread.spec.ts` around lines 59 - 71, The test embeds
UI message literals directly in selectors (page.getByPlaceholder("例: 山田 太郎"),
page.getByRole(..., { name: "変更内容の確認" }), page.getByText("変更点・校正"),
page.getByRole(..., { name: "この内容で保存" })), violating the SSoT rule; update the
spec to import and use the shared message/test constants (or stable test IDs)
instead of inline Japanese strings for those calls, replacing the literal
arguments with the appropriate SSoT constants (or test-id lookups) so UI text
changes won’t break frontend/e2e/career-proofread.spec.ts.

Source: Coding guidelines

frontend/src/utils/careerReview.ts (1)

56-76: 💤 Low value

Consider extracting magic numbers to named constants.

The values 400 (line 59) and 500 (line 75) are used to rank unknown fields for stable sorting. For maintainability, consider extracting these as named constants.

♻️ Suggested refactor

+/** Unknown top-level fields are sorted after known fields, using charCode for stability. */
+const UNKNOWN_TOP_LEVEL_BASE = 400;
+/** Unknown container fields are sorted after known fields within their container. */
+const UNKNOWN_CONTAINER_FIELD_BASE = 500;
+
 /** 既知の並びにあればその index、無ければ末尾側（文字コードで安定ソート）に寄せる。 */
 function orderIndex(list: string[], seg: string): number {
   const i = list.indexOf(seg);
-  return i >= 0 ? i : 400 + (seg.charCodeAt(0) || 0);
+  return i >= 0 ? i : UNKNOWN_TOP_LEVEL_BASE + (seg.charCodeAt(0) || 0);
 }
 
 /**
  * パスを「並び順を表す数値タプル」に変換する。
  * - 先頭セグメント: トップレベル順
  * - 数値セグメント: 配列 index
  * - 名前付きセグメント: 直近の配列名（2 つ前）から決まるコンテナのフィールド順
  */
 function rankTuple(path: string): number[] {
   const segs = path.split(".");
   return segs.map((seg, i) => {
     if (i === 0) return orderIndex(TOP_ORDER, seg);
     if (/^\d+$/.test(seg)) return Number(seg);
     const containerName = i >= 2 && /^\d+$/.test(segs[i - 1]) ? segs[i - 2] : null;
     const order = containerName ? CONTAINER_FIELD_ORDER[containerName] : null;
-    return order ? orderIndex(order, seg) : 500;
+    return order ? orderIndex(order, seg) : UNKNOWN_CONTAINER_FIELD_BASE;
   });
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/src/utils/careerReview.ts` around lines 56 - 76, The code uses magic
numbers 400 and 500 in orderIndex and rankTuple; extract them into named
constants (e.g., UNKNOWN_TOP_ORDER_BASE = 400 and UNKNOWN_FIELD_ORDER = 500) and
replace the literal usages in orderIndex (return i >= 0 ? i :
UNKNOWN_TOP_ORDER_BASE + (seg.charCodeAt(0) || 0)) and in rankTuple’s default
return (return order ? orderIndex(order, seg) : UNKNOWN_FIELD_ORDER) so the
intent is clear and easy to maintain; also add brief comments above the new
constants explaining their purpose.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes